Skip to content

Fix: Correct Firebase environment variable names#44

Open
7vignesh wants to merge 1 commit intoctrixcode:workspacefrom
7vignesh:fix/firebase-env-vars
Open

Fix: Correct Firebase environment variable names#44
7vignesh wants to merge 1 commit intoctrixcode:workspacefrom
7vignesh:fix/firebase-env-vars

Conversation

@7vignesh
Copy link

@7vignesh 7vignesh commented Oct 8, 2025 •
edited by coderabbitai bot
Loading

This commit fixes an issue where the application would crash on startup due to incorrect environment variable names in the Firebase configuration.

  • Corrects AUTHDOMAIN to AUTH_DOMAIN in src/firebase.js for both development and production environments.
  • Updates README.md to document both development and production Firebase environment variables correctly.

Fixes #38

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an authentication domain configuration issue that could cause sign-in failures or inconsistent behavior between development and production. Users should experience more reliable login and session handling.

  • Chores

    • Standardized environment variable names for authentication settings to improve configuration consistency across environments.

@google-labs-jules
Fix: Correct Firebase environment variable names
3f7a8c8 
This commit fixes an issue where the application would crash on startup due to incorrect environment variable names in the Firebase configuration.

- Corrects `AUTHDOMAIN` to `AUTH_DOMAIN` in `src/firebase.js` for both development and production environments.
- Updates `README.md` to document both development and production Firebase environment variables correctly.

Fixes ctrixcode#38
@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025 •
edited
Loading

Walkthrough

Renamed the Firebase authDomain environment variables in src/firebase.js for both development and production from REACT_APP_FIREBASE_AUTHDOMAIN to REACT_APP_FIREBASE_AUTH_DOMAIN. No other configuration fields, initialization logic, or exports were modified.

Changes

Cohort / File(s) Summary
Firebase config env var rename
src/firebase.js		 Updated env var keys: REACT_APP_FIREBASE_DEV_AUTHDOMAIN → REACT_APP_FIREBASE_DEV_AUTH_DOMAIN and REACT_APP_FIREBASE_AUTHDOMAIN → REACT_APP_FIREBASE_AUTH_DOMAIN; no other code changes.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A hop, a skip, a tiny underscore,
I tweaked the keys and nothing more.
Dev and prod now speak the same,
AUTH_DOMAIN earns its rightful name.
Carrots aligned, configs tight—
Ship it swift, ears up, all right! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues Check ⚠️ Warning The pull request correctly updates the AUTHDOMAIN environment variable names to AUTH_DOMAIN in src/firebase.js as required by issue #38 but does not include updates to README.md to document the development environment variables, leaving the documentation incomplete. Please update the README.md to document both the development and production Firebase environment variable names (REACT_APP_FIREBASE_DEV_AUTH_DOMAIN and REACT_APP_FIREBASE_AUTH_DOMAIN) to fully meet issue #38 requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Fix: Correct Firebase environment variable names” accurately and concisely describes the primary change of updating the Firebase environment variable names in the codebase, and it avoids unnecessary detail or noise. It directly aligns with the modifications made to src/firebase.js without including extraneous information.
Out of Scope Changes Check ✅ Passed All changes are confined to src/firebase.js for correcting environment variable names and there are no modifications in unrelated files or logic beyond the scope of issue #38.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3a5f28 and 3f7a8c8.

⛔ Files ignored due to path filters (1)
  • README.md is excluded by !**/*.md and included by none
📒 Files selected for processing (1)
  • src/firebase.js (2 hunks)
🔇 Additional comments (1)
src/firebase.js (1)

8-8: Environment variable renames and docs update verified
Code and README now use REACT_APP_FIREBASE_{DEV_}AUTH_DOMAIN; no AUTHDOMAIN remains. Breaking change: update local .env and CI/CD configs.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct Firebase Development environment variable names and update README

1 participant

@7vignesh